Treat spaces as handled config context options

[mbinna]

Adding keyed parameters for those options inhibits the following warning when using profiles.

Unhandled config context options: {}

[mbinna]

With this change, the spaces are not recognized anymore. For example, when switching profiles with different space suffixes, the directories to the spaces are not updated correctly. So this change does not work as expected. However, I am still wondering how to fix the warning. Therefore, I keep this pull request open.

[wjwwood]

Can you please give a more detailed set of steps to reproduce the warning?

[mbinna]

@wjwwood Sure. Here we go:

1. Start with clean workspace with only src/ directory (no .catkin_tools/ directory)
2. catkin config -> does not show a warning
3. catkin profile add release
4. catkin profile set release
5. catkin config -> shows the warning

Tested with HEAD of master (da79d37).

[wjwwood]

@mbinna I was able to reproduce the issue, but I had to do catkin config --init in the first step.

I'll look into the issue asap.

[racko]

This change doesn't quite work. Try

$ catkin config -d path/to/catkin_ws/devel_linked

and check the Devel Space: output. It will still say path/to/catkin_ws/devel.

Explanation: If you list the spaces as parameters then they won't appear in kwargs. As a result they won't be used in the following code:

catkin_tools/catkin_tools/context.py

Lines 309 to 315 in 47a5b93

	# Handle *space assignment and defaults
	for space, space_dict in Context.SPACES.items():
	key_name = space + '_space'
	default = space_dict['default']
	if space_suffix and space != 'source':
	default += space_suffix
	setattr(self, key_name, kwargs.get(key_name, default))

Instead the defaults will be read from space_dict. That's why the output above stills says path/to/catkin_ws/devel: It's the default.

That's why I created #489. Here I pop the kwargs during the loop and check the remaining number of kwargs afterwards: f67767c

[mikepurvis]

Replaced by #489.