-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add catkin test
verb
#676
Add catkin test
verb
#676
Conversation
Nice work— seems reasonable to me. I tried some time ago but attempted that more ambitious path of trying to reach inside packages and then run individual test targets under catkin's parallelism: https://github.com/mikepurvis/catkin_tools_test/blob/master/catkin_tools_test/test.py Unsurprisingly, this was a total failure; your more restrained approach is the right way to go. |
dcd8730
to
29451b0
Compare
I cannot attest to the complete correctness or code styles but I have tested this PR locally on some packages with different options and it works very well for me. |
9de9d40
to
a97f74d
Compare
Cheers @timonegk, I've used it on a couple of packages and that looked good to me. |
I think |
Thanks for all of the positive feedback! I just added the |
Thanks,
|
Tested here and works very well!! Congrats |
@asherikov, I fixed your issue. I am going to merge this now. |
This pull request adds the long-awaited
catkin test
verb.Summary of the changes
The
test
verb aims to replace the current aliases fortest
andrun_tests
.Currently, calling
catkin test
does the following:make run_tests
in the packagemake test
in the packagecatkin_test_results
for the resultsThe tests are executed in parallel, that can be prevented with
-p 1
.The test output is shown after all the tests of a package are completed, that can be changed with
-i
.Things to do before the merge
test
make targetrun_tests
andtest
--verbose
make cmake_check_build_system
before running tests--make-args
Test it
Please test the new verb on your setup and report any problems or requests in this thread! You can install this version with the command
pip3 install git+https://github.com/catkin/catkin_tools.git@catkin_test
. If the installation was successful,catkin --version
should give the version0.8.0
.