Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clarify creating a custom module #164

Merged
merged 4 commits into from
Mar 17, 2024
Merged

Clarify creating a custom module #164

merged 4 commits into from
Mar 17, 2024

Conversation

qadzek
Copy link
Contributor

@qadzek qadzek commented Mar 16, 2024

As requested by @sgoudham in #90

@qadzek qadzek mentioned this pull request Mar 16, 2024
Closed
@sgoudham sgoudham linked an issue Mar 16, 2024 that may be closed by this pull request
Improve documentation / add examples of custom modules #90
Closed
sgoudham
sgoudham requested changes Mar 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
custom/README.md Outdated Show resolved Hide resolved
@vdbe
Copy link
Contributor

vdbe commented Mar 17, 2024

I quite like the idea of mentioning required plugins for the module at the top like in uptime.
Could this get a place in the template and be mentioned?

qadzek and others added 2 commits March 17, 2024 14:27
@qadzek @sgoudham
Fix path
e0d6f84 
Co-authored-by: Hamothy <58985301+sgoudham@users.noreply.github.com>
@qadzek
Fix formatting and mention required plugins
0c6d2d3
@qadzek
Copy link
Contributor Author

qadzek commented Mar 17, 2024

I quite like the idea of mentioning required plugins for the module at the top like in uptime. Could this get a place in the template and be mentioned?

I am not entirely sure if this is what you had in mind, but at least it's mentioned now.

sgoudham
sgoudham approved these changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Will leave this for @vdbe to merge.

@vdbe vdbe merged commit 2a3bc9e into catppuccin:main Mar 17, 2024
3 checks passed
@qadzek qadzek deleted the improve-docs branch March 17, 2024 15:53
Andreasgdp added a commit to Andreasgdp/tmux-catppuccin that referenced this pull request Mar 19, 2024
@Andreasgdp
Revert "Clarify creating a custom module (catppuccin#164)"
c16325a 
This reverts commit 2a3bc9e.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sgoudham sgoudham sgoudham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation / add examples of custom modules
3 participants
@qadzek @vdbe @sgoudham