-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feature/client-advanced-session-methods #86
Merged
MarkTheHopeful
merged 14 commits into
develop
from
feature/client-advanced-session-methods
Mar 17, 2022
Merged
feature/client-advanced-session-methods #86
MarkTheHopeful
merged 14 commits into
develop
from
feature/client-advanced-session-methods
Mar 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleko
reviewed
Mar 14, 2022
sessionPollingTimer->setInterval(500); | ||
sessionPollingTimer->callOnTimeout([this]() { getSessionInfo(); }); | ||
validationPollingTimer = new QTimer(this); | ||
validationPollingTimer->setInterval(500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
реально 3 полла...
waleko
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
многа кода, но вроде всё по делу
не делай сквош.. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Теперь создание комнаты и запуск игры разделены на разные стадии в соответствии с API и параллельной вектой сервера. Теперь на
ProtoRoomScreen
, который появляется после создания/подключения к комнате есть список игроков, а у хоста ещё и кнопка start game, которая активируется, если текущее состояние комнаты позволяет запуск. Постоянно poll-ится состояние сессии, и, если сессия началась, то все подключённые автоматически закидываются в игру.