-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Zio interoperability #71
Open
Koisell
wants to merge
1
commit into
cb372:main
Choose a base branch
from
Koisell:interop-zio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package retry | ||
|
||
import zio.ZIO | ||
import zio.clock.Clock | ||
import zio.duration.Duration | ||
|
||
import scala.concurrent.duration.FiniteDuration | ||
|
||
object ScalaZIO { | ||
implicit val zioSleep: Sleep[ZIO[Clock, Nothing, ?]] = | ||
new Sleep[ZIO[Clock, Nothing, ?]] { | ||
override def sleep(delay: FiniteDuration): ZIO[Clock, Nothing, Unit] = | ||
ZIO.sleep(Duration.fromScala(delay)) | ||
} | ||
} |
67 changes: 67 additions & 0 deletions
67
modules/zio/shared/src/test/scala/retry/ScalaZIOSpec.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
package retry | ||
|
||
import retry.ScalaZIO._ | ||
|
||
import org.scalatest.flatspec.AnyFlatSpec | ||
import zio.clock.Clock | ||
import zio.duration.{Duration => ZDuration} | ||
import zio.interop.catz._ | ||
import zio.test.mock.mockEnvironmentManaged | ||
import zio.{DefaultRuntime, UIO, ZIO} | ||
|
||
import scala.collection.mutable.ArrayBuffer | ||
import scala.concurrent.duration._ | ||
|
||
class ScalaZIOSpec extends AnyFlatSpec { | ||
|
||
behavior of "retryingM" | ||
|
||
it should "retry until the action succeeds" in new TestContext { | ||
val policy = RetryPolicies.constantDelay[ZIO[Clock, Nothing, ?]](10.second) | ||
|
||
val finalResult = retryingM[Int][ZIO[Clock, Nothing, ?]]( | ||
policy, | ||
_.toInt > 3, | ||
onError | ||
) { | ||
ZIO.effectTotal { | ||
attempts = attempts + 1 | ||
attempts | ||
} | ||
} | ||
|
||
val runtime = new DefaultRuntime {} | ||
val mockRuntime = mockEnvironmentManaged | ||
val f = runtime.unsafeRun { | ||
mockRuntime.use { env => | ||
env.clock.sleep(ZDuration.fromScala(30 seconds)) *> | ||
finalResult.provide(env) | ||
} | ||
} | ||
|
||
assert(f == 4) | ||
assert(attempts == 4) | ||
assert(errors.toList == List(1, 2, 3)) | ||
assert(delays.toList == List(10.second, 10.second, 10.second)) | ||
assert(!gaveUp) | ||
|
||
} | ||
|
||
private class TestContext { | ||
|
||
var attempts = 0 | ||
val errors = ArrayBuffer.empty[Int] | ||
val delays = ArrayBuffer.empty[FiniteDuration] | ||
var gaveUp = false | ||
|
||
def onError(error: Int, details: RetryDetails): UIO[Unit] = { | ||
errors.append(error) | ||
details match { | ||
case RetryDetails.WillDelayAndRetry(delay, _, _) => delays.append(delay) | ||
case RetryDetails.GivingUp(_, _) => gaveUp = true | ||
} | ||
ZIO.unit | ||
} | ||
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long do you think it will be before we see ZIO 1.0.0? Is it worth waiting for that? As I understand it, cats-effect 2.0.0 and Monix 3.0.0 should be out very soon, so it would be nice to do a release with all the dependencies on stable versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know when it will be release but I think it will be soon. I agree we should wait stable versions to make releases.