Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Annotations from events #166

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Annotations from events #166

merged 4 commits into from
Sep 15, 2020

Conversation

abcsds
Copy link
Contributor

@abcsds abcsds commented Sep 7, 2020 •
edited by cbrnr
Loading

Add GUI options to create data annotations from events. Fixes #114.

@cbrnr
Copy link
Owner

cbrnr commented Sep 15, 2020

Thanks @abcsds! This PR gave me a new idea how we could further improve the events/annotations business. Specifically, mne.events_from_annotations returns a tuple with the events and a dictionary mapping events IDs to descriptions. That way, no information is lost in the conversion, and we could use this additional mapping when converting back from events to annotations. WDYT?

@cbrnr cbrnr merged commit 5587fc9 into cbrnr:master Sep 15, 2020
@cbrnr
Copy link
Owner

cbrnr commented Sep 15, 2020

I've created a new issue #167 to discuss this idea.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to convert events to annotations
2 participants
@abcsds @cbrnr