Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add wrapped qt package as dependency fix #182 #187

Merged
merged 7 commits into from
Nov 6, 2020

Conversation

gdolle
Copy link
Contributor

@gdolle gdolle commented Nov 6, 2020

see title.

@gdolle gdolle mentioned this pull request Nov 6, 2020
@cbrnr
Copy link
Owner

cbrnr commented Nov 6, 2020

Thanks @gdolle! Note that this workaround doesn't change requirements.txt, so if you do pip install -r requirements.txt you will get neither PySide2 nor PyQt5. It would be nice to keep all dependencies in requirements.txt, but I don't think this is possible. It's just one more thing to keep in mind, namely that python setup.py install is required for a working installation.

I've added an automatic flake8 check on GitHub, can you please rebase and push to see if that works?

@gdolle
Copy link
Contributor Author

gdolle commented Nov 6, 2020

Yes it is just a workaround (but better than nothing!)

can you please rebase

Ok!

@cbrnr
Copy link
Owner

cbrnr commented Nov 6, 2020

And please also add a short entry in CHANGELOG.md stating that PySide2 will be automatically installed by setuptools if neither PyQt5 nor PySide2 is installed.

@cbrnr cbrnr merged commit 4730be2 into cbrnr:master Nov 6, 2020
@cbrnr
Copy link
Owner

cbrnr commented Nov 6, 2020

Thanks @gdolle!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants