Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show exceptions in an error message box #268

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Conversation

hofaflo
Copy link
Contributor

@hofaflo hofaflo commented Feb 9, 2022

As an example, trying to set a montage with channels not in the chosen configuration leads to this ("Show Details..." shows the full traceback):
image

@cbrnr
Copy link
Owner

cbrnr commented Feb 9, 2022

Very nice addition! How does the traceback look on Windows? On macOS everything is boldface, so it doesn't really look that great (but I think it's OK for now):
Screen Shot 2022-02-09 at 21 13 59

@hofaflo
Copy link
Contributor Author

hofaflo commented Feb 9, 2022

Windows:
image

I was thinking a monospaced traceback would be nice, but I couldn't get it to work on windows :/

@cbrnr
Copy link
Owner

cbrnr commented Feb 9, 2022

I was thinking a monospaced traceback would be nice, but I couldn't get it to work on windows :/

Yeah, same, but for that I think we would have to create a custom dialog anyways (which would then also automatically look better on macOS because we wouldn't use boldface). I'd say this is something for later.

@cbrnr
Copy link
Owner

cbrnr commented Feb 9, 2022

BTW, why is there an ellipsis on the Details button? 🤦

@hofaflo
Copy link
Contributor Author

hofaflo commented Feb 9, 2022

No idea 🤦

@cbrnr cbrnr merged commit 49f7b54 into cbrnr:main Feb 9, 2022
@cbrnr
Copy link
Owner

cbrnr commented Feb 9, 2022

Thanks @hofaflo!

@hofaflo hofaflo deleted the errorbox branch February 9, 2022 20:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants