Show correct history for appending data #446
Conversation
|
I think duplicate names might still be a problem as you mentioned in #130. In my example with two identical names, if you only select one S001R04 in the append dialog, MNELAB still appends both datasets. So I think we need a different solution. In general, there are two options:
The first option is probably easier to implement. The second option would require a couple of changes, e.g. showing the indices in the sidebar and all dialogs that require multiple datasets. WDYT? |
bkloeckl
changed the title
bkloeckl
changed the title
|
I don't know why monkeypatching the decorator doesn't work, but at least this is a workaround. To improve upon that a little, we could think about adding two new parameters |
cbrnr
force-pushed
the
bkloeckl
branch
2 times, most recently
from
da72d48 to
e3346d4
Compare
|
I have parameterized the test to avoid repeating code, and I've also used the |
* Show correct history for appending data * Show correct history for appending data * Changelog entry to PR #446 * Apply Ruff formatting to pass style check * fixed a bug where indexing would be off after auto_duplicate() * simpler append implementation * Add test_model.py with test_append_data. * Adapted Ruff styling and Changelog * Replaced the models dependency for a mainwindow view with a DummyView * Added a view parameter to the model init function with a default value of None * reverted some minor changes with how the models init is handled for tests * Simplify and include function return value * Tweaks * dynamically determine dataset values during runtime for test_append_data asserts * Parameterize test * Fix style * Fix for Python 3.9
Fixes #130. Changes in model.py: def append_data(self, names) to correctly show the code history