-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Sidebar overhaul #454
Sidebar overhaul #454
Conversation
I have two suggestions regarding the behavior of this implementation:
I haven't looked in detail at the changes (will do that soon), but because you changed Also, as we've already discussed, I think you do not have to duplicate the drag and drop behavior (for dropping files), since this is already implemented in I'll review the changes in detail after we've addressed these points. |
The changes in the |
This is a very nice change, I like it a lot! Thanks @bkloeckl! |
* Change the append dialog appearance, get_compatibles and append_data functions to include original indices used for identifying the data * Add changelog entry * Ruff formating * custom TableWidget class for sidebar * drag&drop and tests * core functionalities done * add close-button to sidebar table * styling and changelog * disable hover/mouse-tracking * Revert "Change the append dialog appearance, get_compatibles and append_data functions to include original indices used for identifying the data" This reverts commit 6a9917e. * Revert "Add changelog entry" This reverts commit 916f803. * Revert "Ruff formating" This reverts commit 4e54cd8. * append dialog revert * small close-icon on hover * style and delete old icon * resolve merge conflicts * small changes and clean up code, changed sidebar index styling, remove vertical header * added load file by drag&drop functionality * tiny fix: missing styling in append-dialog * x button dissapears when mouse does not hover over any row anymore * add remove_data() history entry * delegate drag&drop file functionality to parent class to remove duplicated code * ruff error: removed unused import * Set SingleSelection mode * Move to widgets subpackage * Fix changelog entries * Sidebar index is not editable * Remove empty line
Change sidebar UIWidget from List to Table in order to display unique indices of datasets and add a close-button in each row.