Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

📝 Add docstring check to ruff and fix respective errors #331

Merged
merged 7 commits into from
May 7, 2024

Conversation

nquetschlich
Copy link
Collaborator

No description provided.

@nquetschlich nquetschlich added documentation Improvements or additions to documentation enhancement New feature or request labels May 7, 2024
@nquetschlich nquetschlich requested a review from burgholzer May 7, 2024 10:58
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Many thanks! 🙏
Just a couple of suggestions where i think it might make sense to combine comments.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.1%. Comparing base (b1a7118) to head (e5b8d65).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #331     +/-   ##
=======================================
+ Coverage   92.9%   93.1%   +0.2%     
=======================================
  Files         47      47             
  Lines       2437    2437             
=======================================
+ Hits        2264    2270      +6     
+ Misses       173     167      -6     
Flag Coverage Δ
python 93.1% <100.0%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nquetschlich nquetschlich enabled auto-merge (squash) May 7, 2024 11:40
@nquetschlich nquetschlich merged commit 12db850 into main May 7, 2024
18 checks passed
@nquetschlich nquetschlich deleted the add_docstrings branch May 7, 2024 12:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants