🚸 Special case version 4.8.5 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tag has an uppercase Z (Z3-4.8.5) unlike all others. The asset name is also not consistent with the tag, it's lowercase.
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Thanks for the PR! Given the small amount of change required to make this work, we should definitely merge this 👍🏼
I just pushed a couple of commits to clean up the special casing and added a test.
Once CI is all green, I'll merge 🚀
Thanks for the contribution 🙏🏼
burgholzer
changed the title
|
Released as v1.6.1 🚀 https://github.com/cda-tum/setup-z3/releases/tag/v1.6.1 |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the action work for Z3 4.8.5 which was tagged differently and has an uppercase Z in the tag name.