Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix InterfaceOpenMVG and InterfaceVisualSFM build #951

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Fix InterfaceOpenMVG and InterfaceVisualSFM build #951

merged 5 commits into from
Mar 17, 2023

Conversation

yanxke
Copy link
Contributor

@yanxke yanxke commented Mar 13, 2023

Add InterfaceOpenMVG and InterfaceVisualSFM to the default builds. Fix broken build with old interfaces.

cdcseacave and others added 3 commits November 28, 2022 12:28
@cdcseacave
v2.1.0 (cdcseacave#906)
f62b38d 
* Improve depth-map estimation in textureless areas using multi-resolution
* Add texture sharpening
* Ground plane estimation
* Estimate volume from the reconstructed mesh
* Texture transfer between two meshes
* Automatic Region-Of-Interest estimation
* Simplify build with vcpkg
* Add tests
* Add Continuous Integration action
* Various bug fixes
@yanxke
Add apps build.
b4c1fc9
@yanxke
Fix build
407b9d8
@cdcseacave
Copy link
Owner

InterfaceOpenMVG and InterfaceVisualSFM are not buid because they are deprecated, none should be used:
OpenMVG has an exporter for OpenMVS which should be used instead
and VisualSFM is deprecated, both the app and the file format are not doing a good job for these days, use something else instead, like OpenMVG or COLMAP

if you point this PR to master I will merge only the fixes, not the CMake change

@yanxke yanxke changed the base branch from master to develop March 16, 2023 18:36
@yanxke yanxke changed the title Add InterfaceOpenMVG and InterfaceVisualSFM to build Fix InterfaceOpenMVG and InterfaceVisualSFM build Mar 16, 2023
@yanxke
Copy link
Contributor Author

yanxke commented Mar 16, 2023

I've changed the target branch and removed the CMake, though this risks the having the build fail in the future. If they are truly deprecated, then we should just remove the code and also the documentation pointing to their usage. Right now the doc still suggests using InterfaceOpenMVG.

@cdcseacave
Copy link
Owner

good point, I will remove them, thank you

@cdcseacave cdcseacave merged commit 7d4c444 into cdcseacave:develop Mar 17, 2023
@cdcseacave
Copy link
Owner

can you pls point me where in the documentation you see InterfaceOpenMVG mentioned? I did not find it

@yanxke
Copy link
Contributor Author

yanxke commented Mar 17, 2023

documentation

Oh, I guess the outdated documentation is in OpenMVG https://openmvg.readthedocs.io/en/latest/software/MVS/OpenMVS/

@cdcseacave
Copy link
Owner

OpenMVG is not my repo, pls post an issue there

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanxke @cdcseacave