Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement XEP-0280: Message Carbons #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement XEP-0280: Message Carbons #25

wants to merge 1 commit into from

Conversation

singpolyma
Copy link

@singpolyma singpolyma commented Sep 9, 2017 •
edited
Loading

Part of #8

@simmel
Copy link

simmel commented Nov 6, 2017

Works perfectly for me on ejabberd.

@singpolyma-shopify singpolyma-shopify mentioned this pull request Feb 13, 2019
Open
gaaf
gaaf reviewed Oct 24, 2019
View reviewed changes
cdidier
cdidier requested changes Oct 31, 2019
View reviewed changes
Copy link
Owner

@cdidier cdidier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @singpolyma !

I suggested a few coding style changes and a possible memory leak.
Fix those and I'll merge it right away.

@gaaf
Copy link

gaaf commented Apr 16, 2020

Anything still keeping this PR on hold? What can be done to get it accepted?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gaaf gaaf gaaf left review comments

@cdidier cdidier cdidier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singpolyma @simmel @gaaf @cdidier