Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(ci): pin version of cssstyle to allow upgrade-main to succeed #469

Merged
merged 3 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/upgrade-node.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ project.addDevDeps(
"@typescript-eslint/eslint-plugin@^6",
"@typescript-eslint/parser@^6"
);
// This is a temporary workaround to allow upgrade-main to succeed until we upgrade to Node 20
project.package.addPackageResolutions(`cssstyle@4.1.0`);

project.addFields({ publishConfig: { access: "public" } });

Expand Down
3 changes: 3 additions & 0 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions projenrc/upgrade-node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ export class UpgradeNode {
"This PR increases the minimum supported Node.js version",
"to `${{ steps.latest_version.outputs.value }}` from `${{ steps.current_version.outputs.value }}`",
"because version ${{ steps.current_version.outputs.short }} is less than 30 days away from EOL.",
"\n\nWhile this PR could be merged as-is, it is recommended that you scan the code (especially `.projenrc.ts`)",
"to see if there are any comments indicating changes that can/should be made when upgrading Node, such as:",
"\n```// The following line can be removed when upgrading to Node ${{ steps.latest_version.outputs.short }}```",
].join(" "),
labels: "automerge,automated,security",
token: "${{ secrets.PROJEN_GITHUB_TOKEN }}",
Expand Down
2 changes: 2 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ export class CdktfProviderProject extends cdk.JsiiProject {
"@action-validator/core",
"@action-validator/cli"
);
// This is a temporary workaround to allow upgrade-main to succeed until we upgrade to Node 20
this.package.addPackageResolutions(`cssstyle@4.1.0`);

// Default memory is 7GB: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
// Custom Runners we use have 32GB of memory
Expand Down
40 changes: 35 additions & 5 deletions test/__snapshots__/index.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading