Skip to content

Add AsyncIterator Support #8

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Add AsyncIterator Support #8

merged 2 commits into from
Sep 12, 2017

Conversation

developerworks
Copy link
Contributor

All tests passed in the fork. please test again.

…st connections to avoid connections exhausted
@developerworks
Copy link
Contributor Author

image

image

RabbitMqConnectionFactory will caused create many connections,queues like above

@developerworks
Copy link
Contributor Author

developerworks commented Sep 9, 2017

Connetion is reused, but created many queues every time connect to rabbitmq

@cdmbase
Copy link
Owner

cdmbase commented Sep 12, 2017

@developerworks thanks for the PR. I will push your changes.

@cdmbase cdmbase merged commit f1cd86d into cdmbase:master Sep 12, 2017
@groundmuffin
Copy link

Is it graphql-js v. ^0.11.0 compatible? The new subscribe method returns Promise that resolves to AsyncIterator. #918

@cdmbase
Copy link
Owner

cdmbase commented Sep 12, 2017

it is using graphql@^0.10.5

@developerworks
Copy link
Contributor Author

developerworks commented Sep 16, 2017

@groundmuffin The issue is caused by subscriptions-transport-ws, i think you could be waiting subscriptions-transport-ws to repair this issue apollographql/subscriptions-transport-ws#269, in my project, i've downgrade to graphql@^0.10.5

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants