Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecate old EventHandler method signatures #358

Closed
thiell opened this issue Sep 21, 2017 · 0 comments · Fixed by #496
Closed

Deprecate old EventHandler method signatures #358

thiell opened this issue Sep 21, 2017 · 0 comments · Fixed by #496
Labels
Lib
Milestone
1.9

Comments

@thiell
Copy link
Collaborator

thiell commented Sep 21, 2017

Related to #232. Old signatures (eg. ev_read(self, worker)) should be deprecated in 1.x (x > 8) and removed in 2.0.
@thiell thiell added the Lib label Sep 21, 2017
@thiell thiell added this to the 1.9 milestone Sep 21, 2017
@thiell thiell mentioned this issue Nov 23, 2022
Merged
thiell added a commit to thiell/clustershell that referenced this issue Nov 24, 2022
@thiell
Worker: deprecate old EventHandler method signatures (cea-hpc#358)
5c02bd4 
Old EventHandler signatures (eg. ev_read(self, worker)) have been
deprecated since 1.8. This patch adds DeprecationWarnings for 1.9.

Also deprecating Worker.current_* variables in the documentation.
New EventHandler's method arguments should be used instead.

Also updated all tests that were still relying on old signatures.

Closes cea-hpc#358.
@thiell thiell mentioned this issue Nov 24, 2022
Open
thiell added a commit that referenced this issue Nov 24, 2022
@thiell
Worker: deprecate old EventHandler method signatures (#358) (#496)
269ddbd 
Old EventHandler signatures (eg. ev_read(self, worker)) have been
deprecated since 1.8. This patch adds DeprecationWarnings for 1.9.

Also deprecating Worker.current_* variables in the documentation.
New EventHandler's method arguments should be used instead.

Also updated all tests that were still relying on old signatures.

Closes #358.
@thiell thiell mentioned this issue Nov 25, 2022
Merged
thiell added a commit to thiell/clustershell that referenced this issue Nov 25, 2022
@thiell
Event: remove ev_timeout() definition
8adc1e3 
Commit 269ddbd for cea-hpc#358 introduced a
DeprecationWarning for ev_timeout() which doesn't work without
removing the method definition from EventHandler.

Remove the definition from the class, add specific test and update
documentation.
thiell added a commit that referenced this issue Nov 25, 2022
@thiell
Event: remove ev_timeout() definition (#498)
293ad48 
Commit 269ddbd for #358 introduced a
DeprecationWarning for ev_timeout() which doesn't work without
removing the method definition from EventHandler.

Remove the definition from the class, add specific test and update
documentation.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Lib
Projects
None yet
Milestone
1.9
Development

Successfully merging a pull request may close this issue.

Worker: deprecate old EventHandler method signatures (#358) thiell/clustershell
1 participant
@thiell