Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

slurm.conf.example: Filter out more Slurm node state flags #469

Merged
merged 1 commit into from
Jun 18, 2022
Merged

slurm.conf.example: Filter out more Slurm node state flags #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conf/groups.conf.d/slurm.conf.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ reverse: sinfo -h -N -o "%R" -n $NODE
[slurmstate,st]
map: sinfo -h -o "%N" -t $GROUP
all: sinfo -h -o "%N"
list: sinfo -h -o "%T" | tr -d '*~#$@+'
reverse: sinfo -h -N -o "%T" -n $NODE | tr -d '*~#$@+'
list: sinfo -h -o "%T" | tr -d '*~#!%$@+^-'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope Slurm supports UTF-8, as it will eventually exhaust us-ascii special characters... ;)

Wondering if you should not have a different strategy, where you filter only keeping the standard characters and remove all the other ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait for emoji-based node states :)

But more seriously, I think the filtering should ideally not be based on what Slurm states strings could contain. but rather on what is considered acceptable characters in a group name, namely not those:

clustershell/lib/ClusterShell/NodeSet.py

Line 74 in a1875cb

ILLEGAL_GROUP_CHARS = set("@,!&^*")

But I'm not sure we can get that illegal characters list in a group configuration file, can we?

reverse: sinfo -h -N -o "%T" -n $NODE | tr -d '*~#!%$@+^-'
cache_time: 60

#
Expand Down