tree mode: fix error with intermediate gateways (#471) #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intermediate gateways create a TreeWorker with a topology passed by
the parent node and a new root node, and instantiate their own
PropagationNodeRouter object.
When such TreeWorker is scheduled, we should set the task's default
router from it properly.
The error seen was:
...
File "ClusterShell/Propagation.py", line 411, in ev_close
self.task.router.mark_unreachable(gateway)
AttributeError: 'NoneType' object has no attribute 'mark_unreachable'
Fixes cea-hpc#471
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate gateways create a TreeWorker with a topology passed by
the parent node and a new root node, and instantiate their own
PropagationNodeRouter object.
When such TreeWorker is scheduled, we should set the task's default
router from it properly.
The error seen was:
...
File "ClusterShell/Propagation.py", line 411, in ev_close
self.task.router.mark_unreachable(gateway)
AttributeError: 'NoneType' object has no attribute 'mark_unreachable'
Fixes #471