-
Notifications
You must be signed in to change notification settings - Fork 95
[openapi v3.1] PHP 8.2 deprecations #178
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: openapi-31
Are you sure you want to change the base?
[openapi v3.1] PHP 8.2 deprecations #178
Conversation
@cebe LGTM :) |
Suggestion: We might want to add Php 8.2 to |
@pieterocp Whoops good point, I sometimes forget not everyone automated dealing with that out of their mind 😅 . Will either update this PR or file a PR to introduce that. (But probably both.) |
@WyriHaximus As cebe seems don't manage this repository from long time ago, and I have created and published a fork of this library. So if you want to use this changes you can send the PR to https://github.com/DEVizzent/cebe-php-openapi |
@DEVizzent Sure, did you also pull in the other PR's in I have open here? Looks like you also kept the namespaces the same so it's usable as, hopefully, a temporary drop in until @cebe has time for this package again 👍 |
@WyriHaximus No sorry I didn't pull them. If you want to do it it will be great, if not I will do it next weekend. |
@DEVizzent Sure will do 👍 |
@DEVizzent Any plans with the clone you made? Got the PR's in there as you requested but don't seen any activity on them yet |
@WyriHaximus sorry, I didn't get any notification. I will take a look tomorrow. I use to spend time on Open Software all Thursday. |
@DEVizzent Doh yeah then it all makes sense 😂 . |
pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant? |
I think this was implemented in |
No clue, will have a look some time this weekend.
Huh? That change is about yaml, the code in this PR is PHP |
Yes, that is true, but the PHP code changed earlier. https://github.com/cebe/php-openapi/blob/master/src/spec/Paths.php#L186 |
No description provided.