Skip to content

[openapi v3.1] PHP 8.2 deprecations #178

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: openapi-31
Choose a base branch
from

Conversation

WyriHaximus
Copy link

No description provided.

@WyriHaximus WyriHaximus mentioned this pull request Jan 13, 2023
3 tasks
@rogervila
Copy link

@cebe LGTM :)

@pieterocp
Copy link

Suggestion: We might want to add Php 8.2 to .github/workflows/php.yml to reduce the risk of regression going forward.

@WyriHaximus
Copy link
Author

@pieterocp Whoops good point, I sometimes forget not everyone automated dealing with that out of their mind 😅 . Will either update this PR or file a PR to introduce that. (But probably both.)

@DEVizzent
Copy link

@WyriHaximus As cebe seems don't manage this repository from long time ago, and I have created and published a fork of this library. So if you want to use this changes you can send the PR to https://github.com/DEVizzent/cebe-php-openapi

@WyriHaximus
Copy link
Author

@DEVizzent Sure, did you also pull in the other PR's in I have open here? Looks like you also kept the namespaces the same so it's usable as, hopefully, a temporary drop in until @cebe has time for this package again 👍

@DEVizzent
Copy link

@WyriHaximus No sorry I didn't pull them. If you want to do it it will be great, if not I will do it next weekend.

@WyriHaximus
Copy link
Author

@DEVizzent Sure will do 👍

@WyriHaximus
Copy link
Author

@DEVizzent Any plans with the clone you made? Got the PR's in there as you requested but don't seen any activity on them yet

@DEVizzent
Copy link

@WyriHaximus sorry, I didn't get any notification. I will take a look tomorrow. I use to spend time on Open Software all Thursday.

@WyriHaximus
Copy link
Author

@DEVizzent Doh yeah then it all makes sense 😂 .

@cebe
Copy link
Owner

cebe commented Feb 7, 2025

pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant?

@cebe cebe added this to the 1.8.0 milestone Feb 7, 2025
@Sweetchuck
Copy link

I think this was implemented in
(Nov 14, 2024) 2ebe618

@WyriHaximus
Copy link
Author

pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant?

No clue, will have a look some time this weekend.

I think this was implemented in (Nov 14, 2024) 2ebe618

Huh? That change is about yaml, the code in this PR is PHP

@Sweetchuck
Copy link

Yes, that is true, but the PHP code changed earlier.
I haven't check if all the modifications from this PR are already in the master or not. I just check some of them.

https://github.com/cebe/php-openapi/blob/master/src/spec/Paths.php#L186

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants