Update PeriodicTasks on bulk task enable/disable in admin. #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When selecting the admin action "Enable/Disable selected periodic tasks", celery beat is not aware of the update and continues executing newly disabled periodic tasks and ignoring newly enabled periodic tasks.
Solution
Call PeriodicTasks.changed after the update is performed.
Remaining Question
PeriodicTask.save is overriden in djcelery, so I'm unsure if djcelery should be calling the .save() method instead of doing a bulk update of the enabled flag.