Skip to content

update timeutils usage to work with celery 4 #524

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2017
Merged

update timeutils usage to work with celery 4 #524

merged 1 commit into from
Jul 17, 2017

Conversation

ptadas
Copy link
Contributor

@ptadas ptadas commented Jun 9, 2017

No description provided.

auvipy
auvipy previously approved these changes Jun 9, 2017
View reviewed changes
auvipy
auvipy reviewed Jun 9, 2017
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately its all failing

@auvipy auvipy dismissed their stale review June 10, 2017 05:46

test failing

@georgepsarakis georgepsarakis mentioned this pull request Jun 11, 2017
Closed
@georgepsarakis
Copy link

@auvipy @ptadas the failing test was added in https://github.com/celery/django-celery/pull/351/files#diff-fb04340bb23860bdd25c44003fd3430eR104 . _next_id does seem undefined even then. I noticed that at the time there was no Travis CI integration.

@auvipy
Copy link
Member

auvipy commented Jul 17, 2017

should we merge this? and was the issue fixed?

@auvipy auvipy merged commit a052320 into celery:master Jul 17, 2017
maxmalysh pushed a commit to maxmalysh/django-celery that referenced this pull request Jul 29, 2019
@ptadas @maxmalysh
update timeutils usage (celery#524)
2f3e2b4
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@auvipy auvipy auvipy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptadas @georgepsarakis @auvipy