Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Build(deps-dev): Bump pytest from 8.2.0 to 8.2.1" #310

Merged
merged 1 commit into from
May 21, 2024

Conversation

Nusnus
Copy link
Member

@Nusnus Nusnus commented May 21, 2024

Reverts #309

The examples break. It appears to be something with a lack of support with Docker and the newest version.

@Nusnus Nusnus marked this pull request as ready for review May 21, 2024 07:34
@Nusnus Nusnus merged commit 0598e46 into main May 21, 2024
13 of 22 checks passed
@Nusnus Nusnus deleted the revert-309-dependabot/pip/pytest-8.2.1 branch May 21, 2024 07:34
@Nusnus
Copy link
Member Author

Nusnus commented May 21, 2024

I was wrong, the error is more like related to this:

self = <urllib3.poolmanager.PoolManager object at 0x7fc31d4addf0>
request_context = {'block': False, 'cert_reqs': 'CERT_REQUIRED', 'host': 'localhost', 'maxsize': 10, ...}

    def connection_from_context(
        self, request_context: dict[str, typing.Any]
    ) -> HTTPConnectionPool:
        """
        Get a :class:`urllib3.connectionpool.ConnectionPool` based on the request context.
    
        ``request_context`` must at least contain the ``scheme`` key and its
        value must be a key in ``key_fn_by_scheme`` instance variable.
        """
        if "strict" in request_context:
            warnings.warn(
                "The 'strict' parameter is no longer needed on Python 3+. "
                "This will raise an error in urllib3 v2.1.0.",
                DeprecationWarning,
            )
            request_context.pop("strict")
    
        scheme = request_context["scheme"].lower()
        pool_key_constructor = self.key_fn_by_scheme.get(scheme)
        if not pool_key_constructor:
>           raise URLSchemeUnknown(scheme)
E           urllib3.exceptions.URLSchemeUnknown: Not supported URL scheme http+docker

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.27%. Comparing base (6488997) to head (ef47142).
Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   25.27%   25.27%           
=======================================
  Files          37       37           
  Lines        1187     1187           
  Branches      235      235           
=======================================
  Hits          300      300           
  Misses        859      859           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant