Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(pruner | headertest): Deduplicate header generator utilities #3278

Closed
renaynay opened this issue Mar 26, 2024 · 0 comments · Fixed by #4032
Closed

chore(pruner | headertest): Deduplicate header generator utilities #3278

renaynay opened this issue Mar 26, 2024 · 0 comments · Fixed by #4032
Labels
area:header Extended header good first issue Good for newcomers kind:testing Related to unit tests

Comments

@renaynay
Copy link
Member

In pruner/service_test.go, there is a SpacedHeaderGenerator that can be removed in favour of expanding the header generator utility inside of headertest to be able to timestamp headers as is necessary for the unit tests inside of pruner package.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area:header Extended header good first issue Good for newcomers kind:testing Related to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(pruner): remove SpacedHeaderGenerator ronething-bot/celestia-node
1 participant
@renaynay