chore(pruner): remove SpacedHeaderGenerator #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronething-bot
requested review from
renaynay,
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4032 +/- ##
==========================================
+ Coverage 44.83% 45.55% +0.71%
==========================================
Files 265 309 +44
Lines 14620 22184 +7564
==========================================
+ Hits 6555 10105 +3550
- Misses 7313 11007 +3694
- Partials 752 1072 +320 ☔ View full report in Codecov by Sentry. |
renaynay
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Thank you for this contribution @ronething-bot !
The only request i have is to rename the constructor for the test suite to NewTestSuiteWithGenesisTime
|
@renaynay done, please take a review again, thanks. |
|
@renaynay |
|
@renaynay @cristaloleg hi, can we merge this PR now? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3278
This is the first time I'm contributing to the project, and I'm not very familiar with it yet. If i missing something, please left a review comment, thanks.