Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(cmd/blob): fix namespace parsing in cli #4003

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Dec 12, 2024

Closes #4000

@vgonkivs vgonkivs added kind:fix Attached to bug-fixing PRs area:cli labels Dec 12, 2024
@vgonkivs vgonkivs self-assigned this Dec 12, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fastest fix on the west

@vgonkivs
Copy link
Member Author

🤠

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.37%. Comparing base (2469e7a) to head (a76bfbd).
Report is 406 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/blob/cmd/blob.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
+ Coverage   44.83%   45.37%   +0.54%     
==========================================
  Files         265      309      +44     
  Lines       14620    22021    +7401     
==========================================
+ Hits         6555     9993    +3438     
- Misses       7313    10954    +3641     
- Partials      752     1074     +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wondertan
Copy link
Member

This solution works, but imo we shoul just have a smart string -> namespace func somewhere in go sqaure

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree w hlib re go-square comment

@renaynay renaynay merged commit 01bb3e2 into celestiaorg:main Dec 12, 2024
20 of 21 checks passed
@Wondertan
Copy link
Member

@vgonkivs, care for an issue to go-square?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area:cli kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: only hex namespace is supported
4 participants