Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(core/fetcher): resubscribe if consensus node goes offline #4096

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Feb 7, 2025

FIxes #4090.

@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Feb 7, 2025
@vgonkivs vgonkivs self-assigned this Feb 7, 2025
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

core/fetcher.go Outdated Show resolved Hide resolved
walldiss
walldiss previously approved these changes Feb 7, 2025
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but we should prioritise proper fix immediately after. This looks very prone to breaking

core/fetcher.go Show resolved Hide resolved
renaynay
renaynay previously approved these changes Feb 7, 2025
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack, let's get real fix in soon

@renaynay renaynay enabled auto-merge (squash) February 7, 2025 15:44
@vgonkivs vgonkivs dismissed stale reviews from walldiss and renaynay via 13a70d1 February 7, 2025 15:53
cristaloleg
cristaloleg previously approved these changes Feb 7, 2025
@renaynay renaynay merged commit b2e8967 into main Feb 7, 2025
29 of 31 checks passed
@renaynay renaynay deleted the fix_bridge_node branch February 7, 2025 16:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge Node Stuck After Archive RPC Restart
4 participants