Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Instrument Blockchain-API with performance metrics #7402

Closed
yourbuddyconner opened this issue Mar 10, 2021 · 5 comments
Closed

Instrument Blockchain-API with performance metrics #7402

yourbuddyconner opened this issue Mar 10, 2021 · 5 comments
Assignees
Labels
operations ws Issues for the Web Services Circle

Comments

@yourbuddyconner
Copy link
Contributor

yourbuddyconner commented Mar 10, 2021

Blockchain API:

  • RPM (Counter w/ labels for request_verb and endpoint)
  • Response time (Histogram)
  • Response codes (Counter w/ label for response_code)
  • Number of “unknown” transaction types (Gauge (?))

Repo: https://github.com/celo-org/wallet/tree/main/packages/blockchain-api

Recommended course of Action:

@yourbuddyconner yourbuddyconner added the ws Issues for the Web Services Circle label Mar 10, 2021
@yourbuddyconner yourbuddyconner self-assigned this Mar 11, 2021
@yourbuddyconner
Copy link
Contributor Author

Talked with @gnardini about this and we came up with a couple more metrics. We also decided that we'd already identified the most important status metric for this service as being the RPM on a per-endpoint/response-code basis.

  • query_exchange_rate_duration - (Histogram) a measure of the execution duration of the queryExchangeRate method
  • pipeline_duration - (Histogram) a measure of the execution duration of the entire pipeline which is executed for each request, this might overlap with the RPM metrics.
  • get_raw_token_transactions_duration - (Histogram) a measure of the execution duration of the getRawTokenTransactions method which fetches data from blockscout.

@yourbuddyconner
Copy link
Contributor Author

Some examples of the queries/graphs we can make:

Screen Shot 2021-03-17 at 4.53.43 PM.png
Screen Shot 2021-03-17 at 4.50.14 PM.png

@yourbuddyconner
Copy link
Contributor Author

PR for this ticket is here: valora-inc/wallet#115

cc @gnardini and @carterqw2 for review.

@carterqw2
Copy link
Contributor

Agree with the metrics, let's do it.

@yourbuddyconner
Copy link
Contributor Author

PR Closed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
operations ws Issues for the Web Services Circle
Projects
None yet
Development

No branches or pull requests

2 participants