[Feature] Added Prometheus metrics to blockchain-api #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnardini
approved these changes
Mar 18, 2021
carterqw2
reviewed
Mar 18, 2021
| @@ -58,6 +61,8 @@ export class BlockscoutAPI extends RESTDataSource { | |||
| async getRawTokenTransactions(address: string): Promise<Transaction[]> { | |||
| console.info(`Getting token transactions for address: ${address}`) | |||
|
|
|||
| // Measure time at beginning of execution | |||
| const t0 = performance.now() | |||
There was a problem hiding this comment.
Perhaps this timing measurement could be implemented as a decorator.
There was a problem hiding this comment.
I felt doing it this way was a little more granular given I didn't understand the structure of the code I was instrumenting as much. I think that would be a good refactor at least.
yourbuddyconner
force-pushed
the
blockchain-api-metrics
branch
from
561ece9 to
ce920e8
Compare
yourbuddyconner
requested review from
asaj,
cmcewen,
i1skn,
jeanregisser,
jmrossy and
timmoreton
as code owners
yourbuddyconner
force-pushed
the
blockchain-api-metrics
branch
from
0383d7c to
f3436aa
Compare
yourbuddyconner
force-pushed
the
blockchain-api-metrics
branch
from
f3436aa to
f10dabd
Compare
…nto blockchain-api-metrics * 'blockchain-api-metrics' of github.com:celo-org/wallet: Updated yarn.lock
yourbuddyconner
force-pushed
the
blockchain-api-metrics
branch
from
de4c950 to
cf2a899
Compare
tarikbellamine
pushed a commit
that referenced
this pull request
Apr 2, 2021
* added prometheus metrics Co-authored-by: Valentin Rodygin <valentin@clabs.co>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
express-prom-bundlefor prometheus metrics, exposes them at/metrics