Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Jaeger propagator #8

Closed
Nighthawk22 opened this issue May 15, 2019 · 0 comments · Fixed by #9
Closed

Jaeger propagator #8

Nighthawk22 opened this issue May 15, 2019 · 0 comments · Fixed by #9
Assignees

Comments

@Nighthawk22
Copy link
Contributor

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in exporter libraries in other languages. If so, please open an issue on opencensus-specs first.

Is your feature request related to a problem? Please describe.
For my application I need to connect with Jaeger traces that are incoming. Therefore I need to do a propagation with the correct header and the Jaeger header format.

Describe the solution you'd like
My solution is to do it in the same way as the stackdriver exporter does it. https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/tree/master/propagation

The stackdriver exporter implements the HttpFormat of opentracing and returns a SpanContext with the remote tracingID.

Describe alternatives you've considered
I have not found any alternative with opencensus in order to connect existing traces of a remote.

Additional context
I will open a pull request which successfully works with a traefik setup adding a trace to the backend. See screenshot below:
image

@songy23 songy23 added the P1 label May 15, 2019
songy23 pushed a commit that referenced this issue May 16, 2019
* Added jaeger uber-trace-id propagation implementation.

* Changed module name for testing purpose

* Switched order of bytes.

* Revert package name

* Fixed lint error

* Added header length checks in order to not process large invalid headers.
Added testcase for 128bit headers.
Fixed comments.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants