This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Added support for exporting traces from agent through unary grpc #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
commented
Jul 3, 2019
go.mod
Outdated
| @@ -9,3 +9,5 @@ require ( | |||
| google.golang.org/api v0.5.0 | |||
| google.golang.org/grpc v1.21.0 | |||
| ) | |||
|
|
|||
| replace github.com/census-instrumentation/opencensus-proto => github.com/owais/opencensus-proto v0.3.0-pr-202 | |||
There was a problem hiding this comment.
Will be removed once census-instrumentation/opencensus-proto#202 is merged and 0.3.0 is released
6 tasks
owais
force-pushed
the
unary-rpc-exporter
branch
2 times, most recently
from
9a2d978 to
8f0d6be
Compare
- Added `WithUnaryBatchExporter` option to enable unary communication
pjanotti
reviewed
Jul 8, 2019
|
|
||
| default: | ||
| if lastConnectErr := ae.lastConnectError(); lastConnectErr != nil { | ||
| return fmt.Errorf("ExportTraceServiceRequest: no active connection, last connection error: %v", lastConnectErr) |
There was a problem hiding this comment.
Since you're touching this code, could you please move the fmt.Errorf to where the last connection error is set? This way we avoid this formatting code in a possible hot path.
There was a problem hiding this comment.
Thanks. Will do if/when we move forward with up-streaming unary.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on census-instrumentation/opencensus-proto#202