Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Modify the STIX bundle export #170

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

ElJocko
Copy link
Contributor

@ElJocko ElJocko commented Apr 8, 2022

Groups are now secondary objects
x_mitre_domain is filled in for groups
Objects missing an ATT&CK ID are not included in the bundle
LinkById tags are converted to markdown references

Closes #94
Implements STIX bundle part of #168
Implements STIX bundle part of #133

ElJocko added 2 commits April 8, 2022 12:03
Groups are now secondary objects
x_mitre_domain is filled in for groups;
Objects missing an ATT&CK ID are not included in the bundle
LinkById tags are converted to markdown references.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #170 (69257a0) into develop (2f62a8e) will increase coverage by 0.06%.
The diff coverage is 59.52%.

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    55.57%   55.63%   +0.06%     
===========================================
  Files          103      104       +1     
  Lines         5337     5412      +75     
  Branches      1077     1094      +17     
===========================================
+ Hits          2966     3011      +45     
- Misses        1780     1803      +23     
- Partials       591      598       +7     
Impacted Files Coverage Δ
app/controllers/stix-bundles-controller.js 63.63% <ø> (ø)
app/lib/linkById.js 50.00% <50.00%> (ø)
app/services/stix-bundles-service.js 79.79% <71.05%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f62a8e...69257a0. Read the comment docs.

@ElJocko ElJocko merged commit e8356b9 into develop Apr 8, 2022
@ElJocko ElJocko deleted the feature/#133-export-groups branch April 8, 2022 16:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant