Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert LinkById tags to Markdown Links when Exporting a Collection Bundle #183

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ElJocko
Copy link
Contributor

@ElJocko ElJocko commented Apr 29, 2022

Also moves the list of ATT&CK source_name values to a shared location.

…undle.

Move list of ATT&CK source_name values to a shared location.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #183 (3da4f67) into develop (b44f0ae) will increase coverage by 0.01%.
The diff coverage is 65.38%.

@@             Coverage Diff             @@
##           develop     #183      +/-   ##
===========================================
+ Coverage    55.43%   55.45%   +0.01%     
===========================================
  Files          105      105              
  Lines         5498     5518      +20     
  Branches      1123     1126       +3     
===========================================
+ Hits          3048     3060      +12     
- Misses        1834     1840       +6     
- Partials       616      618       +2     
Impacted Files Coverage Δ
app/config/config.js 79.54% <ø> (ø)
app/services/collection-bundles-service.js 69.16% <57.14%> (-0.49%) ⬇️
app/lib/linkById.js 51.92% <62.50%> (+1.92%) ⬆️
app/models/attack-object-model.js 93.75% <100.00%> (ø)
app/services/stix-bundles-service.js 68.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44f0ae...3da4f67. Read the comment docs.

@ElJocko ElJocko merged commit 10509d5 into develop Apr 29, 2022
@ElJocko
Copy link
Contributor Author

ElJocko commented Apr 29, 2022

Closes #168

@clemiller clemiller deleted the feature/#168-linkbyid branch August 28, 2023 16:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting STIX Bundles and Collection Bundles should convert LinkById tags into Markdown References
1 participant