Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: improve mobile view #2085

Merged
merged 5 commits into from
Apr 17, 2024
Merged

chore: improve mobile view #2085

merged 5 commits into from
Apr 17, 2024

Conversation

jpangelle
Copy link
Contributor

@jpangelle jpangelle commented Apr 15, 2024

Description

This pull request improves the mobile view of the home page and the pool detail page.

#1999

Approvals

  • Dev
  • Designer
  • Product

Copy link

github-actions bot commented Apr 15, 2024

PR deployed in Google Cloud
URL: https://app-pr2085.k-f.dev
Commit #: dda69ec
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Apr 15, 2024

PR deployed in Google Cloud
URL: https://pr2085-app-ff-production.k-f.dev
Commit #: dda69ec
To access the functions directly check the corresponding deploy Action

@TimHoub
Copy link

TimHoub commented Apr 15, 2024

Pool listing page:

  • We should use the same way of visualising the pools as we do on desktop -> not the standard table but the card-like table design
  • For the pool card-table we show 'pool name' & 'Value locked' on mobile

Menu

  • bottom menu icons should have a pixel size of 24px + tapable area of 45px. (Added it in the screenshot with the orange square in bottom menu)
Screenshot 2024-04-15 at 11 03 36

Pool detail page

  • Horizontal scroll on the entire page should be removed. Doesn't feel right at the moment. (view screenshot)
  • Invest card doesn't render on mobile (please follow design where possible)
  • Add cashflow chart and transaction table back in the design. (for table I would activate horizontal scroll but only on the table for transactions if possible)
Screenshot 2024-04-15 at 11 15 52

IMG_1119

@jpangelle jpangelle force-pushed the mobile-view-pool-detail-page branch from 28468e3 to 4837fb9 Compare April 15, 2024 18:54
@jpangelle jpangelle force-pushed the mobile-view-pool-detail-page branch from 4837fb9 to c779bb4 Compare April 17, 2024 01:27
@jpangelle jpangelle requested a review from onnovisser April 17, 2024 01:55
@onnovisser onnovisser merged commit b4f0fb2 into main Apr 17, 2024
13 checks passed
@onnovisser onnovisser deleted the mobile-view-pool-detail-page branch April 17, 2024 09:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants