Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prime CNF #2117

Merged
merged 8 commits into from
May 14, 2024
Merged

Prime CNF #2117

merged 8 commits into from
May 14, 2024

Conversation

onnovisser
Copy link
Collaborator

@onnovisser onnovisser commented May 8, 2024

Description

A preview of the Prima page with the CNF address. Also includes several fixes.

Prime overview page

  • Map network chain ID to full name (1 => Ethereum)
  • Remove profit column
  • Fix portfolio value (should be ~8.67M)
  • Retrieve first investment date

Prime detail page

Header

  • The Current portfolio value should be 8.67M, rather than 0
  • There was already an investment made in December 2023 (see also the tx history), but somehow the value shows 0 until Jan 30th

Holdings table

  • The position in Holdings should be around 8.5M, rather than 0
  • The Invest and Redeem buttons should not show up on the Prime page

Transaction history

  • The price of all transactions is the current price, rather than the price when the tx happened (which is stored in the subquery)

Approvals

  • Dev

TODO

  • Revert temp DAO config

Copy link

github-actions bot commented May 8, 2024

PR deployed in Google Cloud
URL: https://app-pr2117.k-f.dev
Commit #: bfd1d89
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented May 8, 2024

PR deployed in Google Cloud
URL: https://pr2117-app-ff-production.k-f.dev
Commit #: bfd1d89
To access the functions directly check the corresponding deploy Action

@onnovisser onnovisser requested review from sophialittlejohn, jpangelle and hieronx and removed request for sophialittlejohn May 13, 2024 13:25
@onnovisser onnovisser marked this pull request as ready for review May 13, 2024 13:25
@onnovisser onnovisser enabled auto-merge (squash) May 14, 2024 07:38
@onnovisser onnovisser merged commit cb9c08e into main May 14, 2024
11 checks passed
@onnovisser onnovisser deleted the prime-cnf branch May 14, 2024 07:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants