hammer: osd: use GMT time for the object name of hitsets #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
changed the title
ghost
self-assigned this
tchaikov
changed the title
|
will add a workaround to address the crc error, instead of disabling the upgrade tests of osd->mon |
tchaikov
force-pushed
the
wip-12848-hammer
branch
from
2c2f3e8 to
87c9e12
Compare
|
changelog
|
tchaikov
changed the title
|
great ! it will be in the next integration branch :-) |
|
that would be great! thanks. |
* bump the encoding version of pg_hit_set_info_t to 2, so we can tell if the corresponding hit_set is named using localtime or GMT * bump the encoding version of pg_pool_t to 20, so we can know if a pool is using GMT to name the hit_set archive or not. and we can tell if current cluster allows OSDs not support GMT mode or not. * add an option named `osd_pool_use_gmt_hitset`. if enabled, the cluster will try to use GMT mode when creating a new pool if all the the up OSDs support GMT mode. if any of the pools in the cluster is using GMT mode, then only OSDs supporting GMT mode are allowed to join the cluster. Fixes: ceph#9732 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 42f8c5d) Conflicts: src/include/ceph_features.h src/osd/ReplicatedPG.cc src/osd/osd_types.cc src/osd/osd_types.h fill pg_pool_t with default settings in master branch.
Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit cc2bcf7) Conflicts: src/mon/OSDMonitor.cc use the old way to dump pool info
Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit 2bc5a48) Conflicts: src/osd/osd_types.cc minor changes to resolve conflicts
* to ease the backport to hammer Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 5a4f6a8) Conflicts: src/include/ceph_features.h minor changes to resolve conflicts
the gmt_hitset is enabled by default in the ctor of pg_pool_t, this is intentional. because we want to remove this setting and make gmt_hitset=true as a default in future. but this forces us to disable it explicitly when preparing a new pool if any OSD does not support gmt hitset. Fixes: ceph#12968 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit e48cec3) Conflicts: src/mon/OSDMonitor.cc remove unrelated hunk
as a workaround of ceph#12410 Fixes: ceph#12968 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-12848-hammer
branch
from
87c9e12 to
f8d2abd
Compare
|
changelog
--- a/ceph-object-corpus
+++ b/ceph-object-corpus
@@ -1 +1 @@
-Subproject commit 47fbf8c6ae1fb4fca171ac86e98821a67fd32031
+Subproject commit ef8a3bd8f5d358bdb40a8d61abd25b24b033ed5b |
|
Ah, thanks for catching that. The integration tests are stalled (test infrastructure problems), no harm done :-) |
ghost
pushed a commit
that referenced
this pull request
Apr 5, 2016
…me of hitsets Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
It passed the hammer upgrade suite ( http://tracker.ceph.com/issues/14692#note-52 ) and the rados suite http://tracker.ceph.com/issues/14692#note-51). |
ghost
merged commit 
This pull request was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13288