Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cip: Crypto Accounts Definition #67

Merged
merged 2 commits into from
Oct 30, 2020
Merged

cip: Crypto Accounts Definition #67

merged 2 commits into from
Oct 30, 2020

Conversation

oed
Copy link
Member

@oed oed commented Sep 30, 2020

PR for CIP-21
Discussion: #44

@oed oed self-assigned this Sep 30, 2020
@oed oed mentioned this pull request Sep 30, 2020
Open
PaulLeCam
PaulLeCam approved these changes Sep 30, 2020
View reviewed changes
Copy link

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if we should use the same name of "Crypto Accounts" or "Crypto Account Links" for both the definition and schema, or it's better to use different names as in the spec?

@oed
Copy link
Member Author

oed commented Sep 30, 2020

My bad @PaulLeCam, forgot to change it everywhere. We should only use Crypto Accounts. Should be updated now!

@oed oed merged commit 508f445 into master Oct 30, 2020
@oed oed deleted the cip/crypto-accounts branch February 16, 2021 08:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@PaulLeCam PaulLeCam PaulLeCam approved these changes

@zachferland zachferland Awaiting requested review from zachferland

Assignees

@oed oed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oed @PaulLeCam