Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update startup_script.sh #84

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

abdulrabbani00
Copy link
Contributor

Not sure what the working branch is for v4, please feel free to change the base and merge.

@abdulrabbani00 abdulrabbani00 changed the base branch from release-v4.1.1-alpha to sharding May 31, 2022 16:25
@abdulrabbani00 abdulrabbani00 merged commit 91d30b9 into sharding May 31, 2022
@abdulrabbani00 abdulrabbani00 deleted the feature/startup-script branch May 31, 2022 16:26
@nikugogoi
Copy link
Contributor

@abdulrabbani00 can you explain why tail -f /dev/null was added?

@abdulrabbani00
Copy link
Contributor Author

@nikugogoi - When we exit the docker container with 0 (or any other return code), it will restart the container. This leads to the container constantly being restarted even if the migration was successful.

From my understanding, the migration only needs to happen once (successfully). Therefore, after it has occurred successfully we use tail -f /dev/null to keep the container running so that it doesn't restart.

Perhaps, instead of simply keeping the container on, we can configure the container to only restart on error. I believe the current configuration is supposed to do that, but for some reason, it wasn't while I was testing. Please feel free to make any changes and remove this logic is you can bypass the container constantly restarting.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants