Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for specifyign a bridge adapter for more complete simulation of Dnase Hi-C. #24

Closed
wants to merge 1 commit into from

Conversation

ShunOuchi
Copy link

Change Points

  • Fixed a bug in ligation site creation
    When Hi-C reads were created with HindIII (A^AGCTT), the ligation site should be AAGCTAGCTT as for as I know, but in sim3C, it was AAGCTAGCTAGCTT. So I fixed it.

  • Fixed an error that occurred when using the linear option
    Errors sometimes occur when using the linear option. So I fixed it.

スクリーンショット 2022-09-27 17 26 14

  • Set initial value of efficiency when -m dnase option is used
    The initial value of efficiency was not specified when using -m dnase option, so it was set.

  • Fixed a bug in which read orientation was fixed when creating Hi-C reads
    In sim3C, the orientation of the reads was fixed as shown in the figure below. But as for as I know, the orientation of the Hi-C reads is generally random. So I fixed it.

スクリーンショット 2022-09-27 17 29 33

  • Added --bridge-adapter option
    Added the function to insert a bridge adapter sequence when using the -m dnase option.

  • Added --sam option
    Added the function to output SAM format files.

@cerebis
Copy link
Owner

cerebis commented Jan 17, 2024

Dear @ShunOuchi

I appreciate this pull request. I've gotten back to maintaining sim3C and I will review what you've contributed.

@cerebis cerebis closed this in fcdfb9e Feb 1, 2024
@cerebis
Copy link
Owner

cerebis commented Feb 1, 2024

I am still interested in better implementing Dnase Hi-C, so I am reopening this PR

@cerebis cerebis reopened this Feb 1, 2024
@cerebis cerebis changed the title bugfix & add new functions (bridge adapter, sam output) Add support for specifyign a bridge adapter for more complete simulation of Dnase Hi-C. Feb 1, 2024
@cerebis cerebis closed this in d4475da Feb 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants