Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validation checks for TOML profiles #37

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Validation checks for TOML profiles #37

merged 6 commits into from
Jan 31, 2024

Conversation

cerebis
Copy link
Owner

@cerebis cerebis commented Jan 31, 2024

  • TOML profile defintions are now checked for missing parameters. Users are warned when a parameter is undeclared, while sim3C will continue with defaults.
  • Float precision has been standardised to 32bit. This is in consideration of PCG base integer RNG, which returns 32bit integers. This is relied upon in generating uniform RNG between [0..1] and thus their precision is also 32-bit. To avoid unforeseen issues when mixing 32 and 64 bit floats in expressions, I have opted to drop handling of PDFs and CDFs to 32 bit.
  • some global references to methods have been removed for clarity. They did not improve performance.
  • a version stamp parameter was added to the TOML profile definition. As there is currently only one version of the format, this simply tests for existence.

@cerebis cerebis merged commit c57b2f3 into master Jan 31, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant