Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

style: too wide search box #3489

Closed
tiborsimko opened this issue Dec 5, 2023 · 1 comment · Fixed by #3497
Closed

style: too wide search box #3489

tiborsimko opened this issue Dec 5, 2023 · 1 comment · Fixed by #3497
Assignees

Comments

@tiborsimko
Copy link
Member

Search for something like "cms" and observe the search results page.

(1) The current production looks like: https://opendata.cern.ch/search?page=1&size=20&q=cms

wide-prod

The problem here was that the search string was "far" from the main page body.

(2) We have addressed the situation during the previous Invenio upgrade sprint in 2021 to bring it closer to the page body, see the master branch at commit 1b8cd22 leading to: http://127.0.0.1:5000/search?q=cms&l=list&order=asc&p=1&s=10&sort=bestmatch

wide-master-old

The search string is now closer to the page body.

(3) The latest Invenio upgrade (#3450) makes the page very wide with the search box going "from coast to coast": https://opendata-dev.cern.ch/search?q=cms&l=list&order=asc&p=1&s=10&sort=bestmatch

wide-master-new

This makes the search string to go again quite far from the page results main body (although it's close to facets!) and makes the page feeing a bit too wide. Imagine a user changing the searched text on the lhs and then changing sorting options or output formatting options on the rhs. Also, the search hit descriptions are running very wide.

Was there a need to go for such a wide-content-box design during latest update? Isn't 2 preferable to 3?

@psaiz
Copy link
Contributor

psaiz commented Dec 11, 2023

See #3497

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants