Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cod: upgrade the invenio dependencies, including opensearch #3450

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

psaiz
Copy link
Contributor

@psaiz psaiz commented Oct 11, 2023

No description provided.

@@ -221,7 +221,7 @@ $break-md: 768px;
filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#ffffff', endColorstr='#ededed', GradientType=1 );

z-index: 999999;
height: calc(100vh-66px);
//height: calc(100vh-66px);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was not working. It might be better to change the syntax instead of commenting it out

"""Redefine invenio search endpoint."""
blueprint_setup.app.view_functions[
'invenio_search_ui.search'] = search_wrapper
#@blueprint.record_once
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this one was needed. If I leave it, it complains

@psaiz psaiz changed the base branch from master to qa October 11, 2023 10:21
@psaiz psaiz changed the base branch from qa to master October 11, 2023 10:22
@psaiz psaiz linked an issue Nov 3, 2023 that may be closed by this pull request
@psaiz psaiz requested a review from zzacharo November 6, 2023 09:06
Dockerfile Outdated Show resolved Hide resolved
@psaiz psaiz force-pushed the invenio_upgrade branch 9 times, most recently from aed902d to ac4cb27 Compare November 13, 2023 18:27
docker-compose-dev.yml Outdated Show resolved Hide resolved
docker-compose-dev.yml Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see something major so I think it is good to be merged and deployed on dev environment for checking. As we discussed IRL, then we should come back to this and remove any commented code that is actually not needed!

@psaiz psaiz merged commit ab9370b into cernopendata:master Nov 28, 2023
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facets: investigate multi-selection issues
3 participants