Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Helm chart OCI release to GH automation #134

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Dec 11, 2024

Adds logic for pushing the Helm chart to an OCI registry (and adding a non-v-prefixed tag)

See cert-manager/makefile-modules#219 for more info.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2024
@inteon inteon force-pushed the add_helm_oci_release branch 3 times, most recently from 5d159f6 to 1c7b09f Compare December 11, 2024 19:51
@inteon inteon requested a review from wallrj December 13, 2024 13:31
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks like that instruction to manually upload the Helm chart was already out of date
The Helm chart was being added to the draft release by the upload-artifact action.
This PR removes that feature, presumably because you think it is redundant. I agree.

I can't see any evidence of a test release, so I presume that you will test this after it merges.

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon force-pushed the add_helm_oci_release branch from f0ae516 to 0d6fd91 Compare December 18, 2024 12:36
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow cert-manager-prow bot merged commit 6b408bb into cert-manager:main Dec 18, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants