Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug: fix ctip parser handling JSON Payload content #2193

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

wagner-intevation
Copy link
Contributor

Handle Payload field with non-base64-encoded JSON content and numbered dictionaries

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #2193 (9a5d17f) into develop (cef39c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9a5d17f differs from pull request most recent head 95d486e. Consider uploading reports for the commit 95d486e to get more accurate results

@@           Coverage Diff            @@
##           develop    #2193   +/-   ##
========================================
  Coverage    76.34%   76.35%           
========================================
  Files          441      441           
  Lines        23649    23658    +9     
  Branches      3739     3741    +2     
========================================
+ Hits         18054    18063    +9     
  Misses        4858     4858           
  Partials       737      737           
Impacted Files Coverage Δ
...s/bots/parsers/microsoft/test_parser_ctip_azure.py 100.00% <ø> (ø)
intelmq/bots/parsers/microsoft/parser_ctip.py 87.09% <100.00%> (+0.57%) ⬆️
intelmq/bots/experts/asn_lookup/expert.py 35.20% <0.00%> (+0.52%) ⬆️
...telmq/bots/experts/recordedfuture_iprisk/expert.py 42.55% <0.00%> (+0.61%) ⬆️
intelmq/bots/experts/maxmind_geoip/expert.py 21.42% <0.00%> (+0.62%) ⬆️
intelmq/bots/experts/tor_nodes/expert.py 47.05% <0.00%> (+0.63%) ⬆️
intelmq/bots/experts/domain_suffix/expert.py 43.33% <0.00%> (+0.63%) ⬆️

@sebix sebix added this to the 3.1.0 milestone Jun 20, 2022
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: bots labels Jun 20, 2022
@sebix sebix requested a review from waldbauer-certat July 15, 2022 08:23
Handle Payload field with non-base64-encoded JSON content and numbered dictionaries
Copy link
Contributor

@waldbauer-certat waldbauer-certat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebix sebix merged commit 469dc49 into certtools:develop Jul 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants