Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TST: Fixed regex to hold gcc version #2216

Merged
merged 2 commits into from
Aug 3, 2022
Merged

TST: Fixed regex to hold gcc version #2216

merged 2 commits into from
Aug 3, 2022

Conversation

waldbauer-certat
Copy link
Contributor

Fixes #2185

@waldbauer-certat waldbauer-certat force-pushed the fix-2185 branch 2 times, most recently from 5e4de75 to 39ef318 Compare July 14, 2022 14:16
@waldbauer-certat waldbauer-certat changed the title TST: Fixed regex to hold gcc version and added correct semver checks TST: Fixed regex to hold gcc version Jul 14, 2022
@waldbauer-certat waldbauer-certat force-pushed the fix-2185 branch 2 times, most recently from de75800 to f0cfad5 Compare July 15, 2022 09:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #2216 (202a1ed) into develop (3b15e09) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2216      +/-   ##
===========================================
- Coverage    76.30%   76.25%   -0.05%     
===========================================
  Files          441      438       -3     
  Lines        23649    23635      -14     
  Branches      3739     3750      +11     
===========================================
- Hits         18046    18024      -22     
- Misses        4864     4872       +8     
  Partials       739      739              
Impacted Files Coverage Δ
intelmq/lib/test.py 91.72% <100.00%> (+0.05%) ⬆️
intelmq/tests/lib/test_test.py 100.00% <100.00%> (ø)
intelmq/bots/outputs/sql/output.py 89.74% <0.00%> (-6.42%) ⬇️
intelmq/lib/mixins/sql.py 51.25% <0.00%> (-3.59%) ⬇️
intelmq/bots/experts/reverse_dns/expert.py 82.25% <0.00%> (-1.62%) ⬇️
intelmq/bots/parsers/microsoft/parser_ctip.py 86.17% <0.00%> (-0.35%) ⬇️
intelmq/lib/pipeline.py 64.56% <0.00%> (-0.15%) ⬇️
intelmq/tests/lib/test_upgrades.py 100.00% <0.00%> (ø)
intelmq/tests/lib/test_parser_bot.py 100.00% <0.00%> (ø)
... and 14 more

Fixes #2185

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
@sebix
Copy link
Member

sebix commented Jul 15, 2022

Did you test the regex with the string ShadowserverJSONParserBot initialized with id test-bot and intelmq 3.0.2 and python 3.10.4 (main, Apr 2 2022, 09:04:19) [GCC 11.2.0] as process 10051.?
It would be easier to test and check with a test case for the regular expression.

@sebix sebix added this to the 3.1.0 milestone Jul 25, 2022
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: tests labels Jul 25, 2022
@wagner-intevation
Copy link
Contributor

@waldbauer-certat I added tests. Please merge if it looks sane to you.

@waldbauer-certat waldbauer-certat merged commit cfe14cb into develop Aug 3, 2022
@sebix sebix deleted the fix-2185 branch August 8, 2022 12:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all bot test fail on Ubuntu 22.04 because of differing python version string
4 participants