intelmqctl: On stop wait longer for bots to be stopped #2598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the 3.10 pytest fail is unrelated (see #2602) |
|
I put quite some comments in there. Looking at the other code, I see much less comments. If I should shrink the comments just let me know. |
Please not, inline comments are great :) |
|
Alright then. The tests (that shall pass) pass. Any additional feedback? (also notify if not, so I can squash the commits into one commit) |
retry multiple times on `intelmqctl stop` to check if bots really stopped, since the bots might take longer to stop. Using retry in constrast to increasing the sleep_time keeps the delay short in case the bots did already stop.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2595
retry multiple times on
intelmqctl stopto check if bots really stopped, since the bots might take longer to stop. Using retry in constrast to increasing the sleep_time keeps the delay short in case the bots did already stop.Note: I intend to make at least the amount of retries performed configurable so that if the current total
sleep_timeof 4.75 seconds does not suffice for some users they are able to increase it.