Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add CI step to ensure a changelog entry is added #1662

Open
ueman opened this issue Feb 16, 2023 · 0 comments
Open

Add CI step to ensure a changelog entry is added #1662

ueman opened this issue Feb 16, 2023 · 0 comments
Labels
infra

Comments

@ueman
Copy link
Contributor

ueman commented Feb 16, 2023

Request Statement

We should add a CI job, which ensures that a PR always adds a changelog entry.
We can avoid things like this follow-up by doing that.
@ueman ueman added the infra label Feb 16, 2023
@AlexV525 AlexV525 mentioned this issue Feb 20, 2023
Merged
7 tasks
AlexV525 added a commit that referenced this issue Feb 20, 2023
@AlexV525
Add the CHANGELOG requirement in the PR template (#1679)
9909245 
The comment would be an example. Related to #1662. This would be a
temporary solution until we can have a robust check.

### New Pull Request Checklist

- [ ] I have read the
[Documentation](https://pub.dev/documentation/dio/latest/)
- [ ] I have searched for a similar pull request in the
[project](https://github.com/cfug/dio/pulls) and found none
- [ ] I have updated this branch with the latest `main` branch to avoid
conflicts (via merge from master or rebase)
- [ ] I have added the required tests to prove the fix/feature I'm
adding
- [ ] I have updated the documentation (if necessary)
- [ ] I have run the tests without failures
- [ ] I have updated the `CHANGELOG.md` in the corresponding package

### Additional context and info (if any)

<!-- Provide more context and info about the PR. -->

Signed-off-by: Alex Li <github@alexv525.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ueman