Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add persistentConnection option #1584

Closed
wants to merge 2 commits into from
Closed

Add persistentConnection option #1584

wants to merge 2 commits into from

Conversation

FredJul
Copy link

@FredJul FredJul commented Oct 28, 2022

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest develop to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass

Pull Request Description

This PR adds the "persistentConnection" options (which is backed by HttpClientRequest.persistentConnection). If you chain lot of requests it can be necessary to disable this option to avoid a connection close.

@AlexV525
Copy link
Member

Hi @FredJul. We've made our hardfork repo public and published a new version of dio, named diox.
The new package contains the PR of the fix.
Please refer to https://pub.dev/packages/diox/versions/5.0.0-dev.1 to use the fork.
You can also see why we're working for a hardfork at cfug/diox#29 and #1607.

@AlexV525 AlexV525 closed this Feb 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants