Improve detection of focus changes #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2020
* exwm-input.el: (exwm-input--on-buffer-list-update): Keep track of last selected window and buffer, update focus only when any of those changes. (exwm-input--update-focus-defer): Add commentary. (exwm-input--update-focus-window-buffer): Add variable. Copyright-paperwork-exempt: yes Co-Author: Adrián Medraño Calvo <adrian@medranocalvo.com>
* exwm-input.el: (exwm-input--on-buffer-list-update): Stop checking `exwm-input--skip-buffer-list-update'; it's no longer needed now that we keep track of the last selected window and buffer. (exwm-input--skip-buffer-list-update): Remove variable. * exwm-manage.el (exwm-manage--manage-window): Remove binding of `exwm-input--skip-buffer-list-update'.
medranocalvo
force-pushed
the
update-focus-upon-selected-window-only
branch
from
ad8cddc
to
2402413
Compare
|
I haven't rigorously tested it but, while edit: Ah, wait, was I'm not sure if this was even supposed to help with #756. |
|
@medranocalvo Do you think we should merge it anyway? It should help alleviate other problems at least. |
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this pull request
Jun 5, 2023
This is almost one year of changes to EXWM. Note that it undoes our port of ch11ng/exwm#737 That PR hasn't seen any movement in three years, so it might not be that relevant anymore. Other stuff has been mainlined in the meantime. Change-Id: I0845ff8a28a5bb1553855f6d6f0ceeaedcf0809e
|
Applied this to my fork https://github.com/bendlas/exwm I think it fixes the focus problems, I've been having .. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should limit substantially the number of
on-buffer-list-updateswe react to. Especially, it should ignore allwith-temp-buffer, as those don't select a different window (note that we use(window-buffer (selected-window))and not(current-buffer)).A further improvement could be to check that the selected window belongs to an EXWM-managed frame (workspace, floating, minibuffer(?)).