Adding members and memberEquals assertions

[NickHeiner]

Checking for subsets and set equality. Implements #148.

Let me know if there's anything I'm doing that's not up to the project standards. I've tried to be observant.

[logicalparadox]

Looks pretty good, but I do have a few comments.

• I would still prefer that this be implemented in the same way as keys() as I outlined in this comment by using the include/contain flag for subsets.
• Please do not include the browser build chai.js in your commit. Travis-CI will rebuild it anyway so PR CI always reflects your changes.

[logicalparadox]

Official code style guideline: wiki

[NickHeiner]

Thanks for the wiki link. Can you clarify exactly what you mean in terms of implementing it like keys()? Did you mean internally or externally?

Are the following syntaxes acceptable?

// subset
expect([1, 2, 3]).to.include.members([1, 2]);

// set equality
expect([1, 2, 3]).to.have.same.members([3, 2, 1])

[logicalparadox]

Those syntaxes are exactly what I mean 👍

[NickHeiner]

bump - any update on this?

[logicalparadox]

It looks to me like members doesn't have a non-flag assertion; you need to use either same or include. What would happen if I wrote it shorthand...

expect([ 1, 2, 3 ]).members([ 3, 2, 1 ]);

You need a default assertion for your primary method. Remove same as a flag and just add it as a chainable with that and the others. Then modify members so that the same assertion is the default if no flags are set. Then we should be good to go.

[NickHeiner]

bump

[logicalparadox]

Sorry about delay ... I didn't get notified about your push. Looks good. Merging!

[NickHeiner]

Awesome, thanks!